-
Notifications
You must be signed in to change notification settings - Fork 401
Fix expected-cfg-checks for logging features #3425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix expected-cfg-checks for logging features #3425
Conversation
Rustc 1.84 (nightly) introduced that the `unexpected_cfg`s lint will now be reported for external macros (see rust-lang/rust#132577), leading to some of our builds failing due to our `level = "forbid"` config of unexpected cfg flags. Here, we add the logging features to the expected features of the workspace to mitigiate this issue and fix builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, thank you!
I think the error is telling us something is actually broken here - we're checking the |
Ugh, duh. Good point. I wonder if it would be worth dropping the logging features generally, since they seem to be a continuing source of user error/confusion, and likely very few people want to hard-code a maximum log level at compile time? |
I'd be okay with that. Originally was thinking that logging would imply more allocations than it actually does thanks to |
Hmm, alright. I wonder if @enigbe would be interested in picking up dropping the |
Closing this for now. |
Fixes #3424.
Rustc 1.84 (nightly) introduced that the
unexpected_cfg
s lint will now be reported for external macros (seerust-lang/rust#132577), leading to some of our builds failing due to our
level = "forbid"
config of unexpected cfg flags.Here, we add the logging features to the expected features of the workspace to mitigiate this issue and fix builds.