Follow-ups to #3436 #3493
Merged
Follow-ups to #3436 #3493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We address some minor mistakes that made it into the docs before.
|
Still needs a fix for #3436 (comment) and #3436 (comment) |
When a peer misbehaves/sends bogus data we reply with an error message and insert it to the ignored list. Here, we avoid having this list grow unboundedly over time by removing peers again once they disconnect, allowing them a second chance upon reconnection.
Previously, we wouldn't set the field as we aren't yet making use of it. Here, we start setting the field. To this end, we make `best_block` an `RwLock<Option<BestBlock>>` rather than `Option<RwLock<BestBlock>>`.
Done. |
arik-so
previously approved these changes
Dec 19, 2024
TheBlueMatt
previously approved these changes
Dec 19, 2024
lightning-liquidity/README.md
Outdated
| @@ -2,13 +2,18 @@ | |||
|
|
|||
| The goal of this crate is to provide types and primitives to integrate a spec-compliant LSP with an LDK-based node. To this end, this crate provides client-side as well as service-side logic to implement the [LSP specifications]. | |||
|
|
|||
| **Note**: Service-side support is currently considered "beta", i.e., not fully | |||
| ready for producttion use. | |||
There was a problem hiding this comment.
Suggested change
| ready for producttion use. | |
| ready for production use. |
As a few things are missing (most importantly persistence), we add notes that the service-side integration is currently considered 'beta'.
tnull
force-pushed
the
2024-12-3436-followup
branch
from
508ee8c to
dd91418
Compare
|
Force-pushed the following changes: > git diff-tree -U2 508ee8c8f dd9141846
diff --git a/lightning-liquidity/README.md b/lightning-liquidity/README.md
index c53a9f2ad..dd74ba830 100644
--- a/lightning-liquidity/README.md
+++ b/lightning-liquidity/README.md
@@ -4,5 +4,5 @@ The goal of this crate is to provide types and primitives to integrate a spec-co
**Note**: Service-side support is currently considered "beta", i.e., not fully
-ready for producttion use.
+ready for production use.
Currently the following specifications are supported:
diff --git a/lightning-liquidity/src/lib.rs b/lightning-liquidity/src/lib.rs
index 95686fcc5..520c20098 100644
--- a/lightning-liquidity/src/lib.rs
+++ b/lightning-liquidity/src/lib.rs
@@ -12,5 +12,5 @@
//!
//! **Note**: Service-side support is currently considered "beta", i.e., not fully ready for
-//! producttion use.
+//! production use.
//!
//! Currently the following specifications are supported: |
TheBlueMatt
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3488.
Follow-ups to #3436: