Skip to content

Deprecate pay_for_offer_from_human_readable_name #4083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnull merged 1 commit into from
Sep 18, 2025
Merged

Deprecate pay_for_offer_from_human_readable_name #4083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lightning-dns-resolver/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,7 @@ mod test {
let amt = 42_000;
let mut opts = OptionalOfferPaymentParams::default();
opts.payer_note = payer_note.clone();
#[allow(deprecated)]
nodes[0]
.node
.pay_for_offer_from_human_readable_name(name, amt, payment_id, opts, resolvers)
Expand Down
12 changes: 5 additions & 7 deletions lightning/src/ln/channelmanager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12600,13 +12600,10 @@ where
/// Pays for an [`Offer`] looked up using [BIP 353] Human Readable Names resolved by the DNS
/// resolver(s) at `dns_resolvers` which resolve names according to [bLIP 32].
///
/// If the wallet supports paying on-chain schemes, you should instead use
/// [`OMNameResolver::resolve_name`] and [`OMNameResolver::handle_dnssec_proof_for_uri`] (by
/// implementing [`DNSResolverMessageHandler`]) directly to look up a URI and then delegate to
/// your normal URI handling.
///
/// Alternatively, the [`bitcoin-payment-instructions`] crate provides an implementation of
/// much of this logic, and may be useful to decode and resolve payment instructions generally.
/// Because most wallets support on-chain or other payment schemes beyond only offers, this is
/// deprecated in favor of the [`bitcoin-payment-instructions`] crate, which can be used to
/// build an [`OfferFromHrn`] and call [`Self::pay_for_offer_from_hrn`]. Thus, this method is
/// deprecated.
///
/// # Payment
///
Expand Down Expand Up @@ -12638,6 +12635,7 @@ where
/// [`PaymentFailureReason::UserAbandoned`]: crate::events::PaymentFailureReason::UserAbandoned
/// [`PaymentFailureReason::InvoiceRequestRejected`]: crate::events::PaymentFailureReason::InvoiceRequestRejected
#[cfg(feature = "dnssec")]
#[deprecated(note = "Use bitcoin-payment-instructions and pay_for_offer_from_hrn instead")]
pub fn pay_for_offer_from_human_readable_name(
&self, name: HumanReadableName, amount_msats: u64, payment_id: PaymentId,
optional_params: OptionalOfferPaymentParams, dns_resolvers: Vec<Destination>,
Expand Down
Loading