-
Notifications
You must be signed in to change notification settings - Fork 421
Make background-processor NO_*
constants actually Send
+ Sync
#4132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make background-processor NO_*
constants actually Send
+ Sync
#4132
Conversation
👋 Thanks for assigning @tnull as a reviewer! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4132 +/- ##
==========================================
- Coverage 88.63% 88.60% -0.03%
==========================================
Files 180 180
Lines 134878 134904 +26
Branches 134878 134904 +26
==========================================
- Hits 119543 119535 -8
- Misses 12567 12601 +34
Partials 2768 2768
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add some test coverage for this case then?
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
68ca292
to
d666e4c
Compare
In 0d59d73 we added constants to better enable users to call background processor methods without optional parameters. Sadly, they didn't work for the async BP as they weren't actually `Send` + `Sync`, which we fix here.
d666e4c
to
e040fcd
Compare
Fixed the no-std build and added test coverage. |
In 0d59d73 we added constants to better enable users to call background processor methods without optional parameters. Sadly, they didn't work for the async BP as they weren't actually
Send
+Sync
, which we fix here.