Skip to content

Conversation

TheBlueMatt
Copy link
Collaborator

In 0d59d73 we added constants to better enable users to call background processor methods without optional parameters. Sadly, they didn't work for the async BP as they weren't actually Send + Sync, which we fix here.

@TheBlueMatt TheBlueMatt added this to the 0.2 milestone Sep 27, 2025
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Sep 27, 2025

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Copy link

codecov bot commented Sep 27, 2025

Codecov Report

❌ Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.60%. Comparing base (19a9dbd) to head (e040fcd).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lightning-background-processor/src/lib.rs 93.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4132      +/-   ##
==========================================
- Coverage   88.63%   88.60%   -0.03%     
==========================================
  Files         180      180              
  Lines      134878   134904      +26     
  Branches   134878   134904      +26     
==========================================
- Hits       119543   119535       -8     
- Misses      12567    12601      +34     
  Partials     2768     2768              
Flag Coverage Δ
fuzzing 21.76% <ø> (ø)
tests 88.44% <93.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tnull tnull requested review from tnull and removed request for valentinewallace September 28, 2025 07:46
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add some test coverage for this case then?

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@TheBlueMatt TheBlueMatt force-pushed the 2025-09-async-bp-consts branch 5 times, most recently from 68ca292 to d666e4c Compare September 28, 2025 16:15
In 0d59d73 we added constants to
better enable users to call background processor methods without
optional parameters. Sadly, they didn't work for the async BP as
they weren't actually `Send` + `Sync`, which we fix here.
@TheBlueMatt TheBlueMatt force-pushed the 2025-09-async-bp-consts branch from d666e4c to e040fcd Compare September 28, 2025 16:26
@TheBlueMatt
Copy link
Collaborator Author

Fixed the no-std build and added test coverage.

@TheBlueMatt TheBlueMatt requested a review from tnull September 28, 2025 17:40
@tnull tnull merged commit 27cf31a into lightningdevkit:main Sep 30, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants