Assert peer supports splicing before splicing channel

[tankyleo]

No description provided.

[ldk-reviews-bot]

👋 I see @wpaulino was un-assigned.
If you'd like another reviewer assignment, please click here.

[tankyleo]

Question: if a peer connects to us with splicing on, and quiesence off, should we immediately disconnect ?

[TheBlueMatt]

Oops lol

[codecov]

Codecov Report

❌ Patch coverage is 96.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.33%. Comparing base (109f715) to head (cdba25f).
⚠️ Report is 9 commits behind head on main.

Files with missing lines	Patch %	Lines
lightning/src/ln/splicing_tests.rs	95.55%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4262      +/-   ##
==========================================
+ Coverage   89.30%   89.33%   +0.03%     
==========================================
  Files         180      180              
  Lines      139057   139111      +54     
  Branches   139057   139111      +54     
==========================================
+ Hits       124182   124273      +91     
+ Misses      12247    12209      -38     
- Partials     2628     2629       +1     

Flag	Coverage Δ
fuzzing	34.99% <45.45%> (-0.01%)	⬇️
tests	88.69% <96.42%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tankyleo]

@TheBlueMatt is that a backport to 0.2 ?

[TheBlueMatt]

Probably should be, yea.

[TheBlueMatt]

Backported in #4344