Refactor logic for setting initial_routing_sync feature bit #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeerManager determines whether the initial_routing_sync feature bit should be set when sending Init messages to peers. Move this to the Router as it is better able to determine if a full sync is needed.
jkczyz
changed the title
TheBlueMatt
approved these changes
Feb 10, 2020
arik-so
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor logic for setting
initial_routing_syncfeature bit, moving it fromPeerManagertoRouter. This eases an upcoming refactoring of peer_handler.rs and moves the logic to a more appropriate place since the router would know best as to whether a full sync is needed.