multi: update ChannelManager tx broadcaster from Arc to Deref #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinewallace
force-pushed
the
chanmgr-tx-broadcaster-to-deref
branch
from
ba6d353 to
14a8ca5
Compare
TheBlueMatt
reviewed
Feb 24, 2020
valentinewallace
force-pushed
the
chanmgr-tx-broadcaster-to-deref
branch
4 times, most recently
from
94538b3 to
d7aebb7
Compare
TheBlueMatt
reviewed
Feb 25, 2020
Collaborator
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
Looks good. One stray nit and good to go.
valentinewallace
force-pushed
the
chanmgr-tx-broadcaster-to-deref
branch
from
d7aebb7 to
d768cc2
Compare
Contributor
Author
Done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo: should break up into multiple commits for reviewability (even though they'll have to be squashed in the end for git bisect reasons).
It's basically the same as #443 though, mostly mechanical changes.
Partially addresses #237.