Flatten ChannelMonitor substructs that don't add clarity #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinewallace
approved these changes
Mar 23, 2020
Contributor
valentinewallace
left a comment
valentinewallace
left a comment
There was a problem hiding this comment.
Always nice to end up with less code than you started with!
LGTM 🏄♀️
The new OnchainDetection struct (which is the remnants of the old KeyStorage enum, which was removed in 1dbda4f) doesn't really add any clarity to ChannelMonitor, so best to just drop it and move its members into ChannelMonitor directly.
TheBlueMatt
force-pushed
the
2020-03-555-nits
branch
from
85edf94 to
b49e63b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new OnchainDetection struct (which is the remnants of the old
KeyStorage enum, which was removed in 1dbda4f)
doesn't really add any clarity to ChannelMonitor, so best to just
drop it and move its members into ChannelMonitor directly.