Support building a cdylib and skip libbitcoinconsensus in wasm32 #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This, combined with rust-bitcoin/rust-secp256k1#208 should get us building in wasm again, hopefully without any future complications due to WASM's lack of standard stdlibc.
TheBlueMatt
force-pushed
the
2020-04-wasm
branch
from
7c36eaf to
be45f67
Compare
|
Gonna let this sit until we land rust-bitcoin/rust-secp256k1#208 then hopefully we can do travis tests with wasm-bindgen or so. |
|
Closing. Makes more sense to move forward with WASM based on #618 not direct RL calls. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This, combined with
rust-bitcoin/rust-secp256k1#208 should get
us building in wasm again, hopefully without any future
complications due to WASM's lack of standard stdlibc.