Skip to content

Bump MSRV to 1.30.0 #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 1 commit into from
Aug 19, 2020
Merged

Bump MSRV to 1.30.0 #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ jobs:
matrix:
toolchain: [ stable,
beta,
# 1.22.0 is MSRV for rust-lightning in general:
1.22.0,
# 1.30.0 is MSRV for Rust-Lightning
1.30.0,
# 1.34.2 is Debian stable
1.34.2,
# 1.39.0 is MSRV for lightning-net-tokio and generates coverage
Expand Down
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ language: rust
rust:
- stable
- beta
# 1.22.0 is MSRV for rust-lightning in general:
- 1.22.0
# 1.30.0 is MSRV for rust-lightning in general:
- 1.30.0
# 1.34.2 is Debian stable
- 1.34.2
# 1.39.0 is MSRV for lightning-net-tokio and generates coverage
Expand Down
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ be covered by functional tests.
When refactoring, structure your PR to make it easy to review and don't
hestitate to split it into multiple small, focused PRs.

The Minimal Supported Rust Version is 1.22.0 (enforced by our Travis).
The Minimal Supported Rust Version is 1.30.0 (enforced by our Travis and
GitHub Actions).

Commits should cover both the issue fixed and the solution's rationale.
These [guidelines](https://chris.beams.io/posts/git-commit/) should be kept in mind.
Expand Down