Skip to content

Conversation

G8XSU
Copy link
Contributor

@G8XSU G8XSU commented Nov 28, 2023

Closes #4

@G8XSU G8XSU marked this pull request as draft December 4, 2023 20:38
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems you'll need to pin at least regex in CI, possibly some other dependencies, too.

See https://github.com/lightningdevkit/rust-lightning/blob/3751398518cb5c9b26a596c0dc9b33571abcf756/ci/ci-tests.sh#L60-L61.

@tnull
Copy link
Contributor

tnull commented Feb 12, 2024

Would be good to move forward with this since we're about to add additional dependencies which need to comply with our MSRV.

@G8XSU G8XSU marked this pull request as ready for review August 22, 2024 23:48
@G8XSU G8XSU requested a review from tnull August 22, 2024 23:56
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@G8XSU G8XSU merged commit 894b020 into lightningdevkit:main Aug 23, 2024
@G8XSU G8XSU mentioned this pull request Aug 23, 2024
G8XSU added a commit to G8XSU/vss-rust-client that referenced this pull request Aug 23, 2024
Major Changes include:
* Signature change in vss-client constructor. (in lightningdevkit#31 )
* Vss-client can now also return AuthError if AuthException is returned from server. (lightningdevkit#30)
* Adds VssHeaderProvider, can be used for auth and request signing.(lightningdevkit#31)
* Adds LnurlAuthToJwtProvider, provides LnUrl based JWT auth. (lightningdevkit#26)
* Adds KeyObfuscator, to provide client-side key obfuscation. (lightningdevkit#32)
* Package now has enforced MSRV of 1.63.0. (lightningdevkit#19)

This is a minor version bump because there are non-backward compatible changes in vss-client usage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Start enforcing some(MSRV)

2 participants