This repository has been archived by the owner on Feb 23, 2021. It is now read-only.
Add parameter to customize Wait screen copy. #1152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanx
suggested changes
Jun 28, 2019
src/action/wallet.js
Outdated
| @@ -245,7 +246,7 @@ class WalletAction { | |||
| this.initResetPassword(); | |||
| return this._notification.display({ msg: errorMsg }); | |||
| } | |||
| this._nav.goWait(); | |||
| this._payment.initWaitScreen({ copy: 'Updating password...' }); | |||
There was a problem hiding this comment.
Why does the wallet need access to the payment action for this? Would probably be cleaner to either:
a. create a wait action
b. let actions call nav.goWait({ copy: 'Updating password...' }) and set store.waitScreenCopy` in the nav action
Considering it's only a one liner, I'd lean towards b.
There was a problem hiding this comment.
Just remembered this PR exists lol. Updating!
valentinewallace
force-pushed
the
dev/wait-screen-copy
branch
from
93619eb
to
2156998
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1038.