Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lnd and golang versions #74

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Bump lnd and golang versions #74

merged 2 commits into from
Mar 30, 2023

Conversation

guggero
Copy link
Member

@guggero guggero commented Mar 29, 2023

This PR isn't needed for packaging a new litd version, so no hurry with it. We should test this well first, since there could be some hidden changes in the updated wasm_exec.js from the Golang 1.19.7 release. And this might require a change in the Terminal Web repo as well.

@jamaljsr
Copy link
Member

jamaljsr commented Mar 29, 2023

When running make example-server then clicking on the "Initiate the client" button on the web page, I'm getting the following error in the browser console.

Error running wasm client: field Chain must be set to create chainrpc
13:37:17.836 wasm_exec.js:170 exit code: 1
exit @ wasm_exec.js:170
runtime.wasmExit @ wasm_exec.js:294
$func1198 @ wasm-client.wasm:0x116acc
$func1186 @ wasm-client.wasm:0x1168fa
$func1094 @ wasm-client.wasm:0x10faf0
$func2566 @ wasm-client.wasm:0x229f98
$func33602 @ wasm-client.wasm:0x1d8cd8b
$func33581 @ wasm-client.wasm:0x1d83629
$func682 @ wasm-client.wasm:0xa93da
$func1183 @ wasm-client.wasm:0x1168b3
$run @ wasm-client.wasm:0x116886
run @ wasm_exec.js:596
startInstance @ (index):81
(anonymous) @ (index):87
Promise.then (async)
initClient @ (index):86
onclick @ (index):285
13:37:17.958 (index):76 Uncaught TypeError: Cannot read properties of undefined (reading 'wasmClientStatus')
    at connStatus ((index):76:44)

@guggero
Copy link
Member Author

guggero commented Mar 30, 2023

I bumped the litd version and tested it against my 0.9.0 mainnet one, seems to work now.

@guggero guggero marked this pull request as ready for review March 30, 2023 15:28
Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 🚀

Tested with TW and confirmed I'm getting the new Loop proto fields in the responses. Thank you for the update.

@jamaljsr jamaljsr merged commit 12ce03a into master Mar 30, 2023
@jamaljsr jamaljsr deleted the lnd-0-16-0-final branch March 30, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants