Skip to content

Conversation

jamaljsr
Copy link
Member

@jamaljsr jamaljsr commented Jun 10, 2020

This PR will be an accumulation of small fixes and improvements found during internal testing.

Pending Confirmation

@jamaljsr jamaljsr force-pushed the rc-feedback-fixes branch from ad4a67b to 427994f Compare June 12, 2020 14:16
@jamaljsr jamaljsr force-pushed the rc-feedback-fixes branch from 5ac24ec to abe9249 Compare June 13, 2020 03:23
@jamaljsr jamaljsr force-pushed the rc-feedback-fixes branch from 603babf to f2401db Compare June 16, 2020 16:35
@jamaljsr jamaljsr requested a review from guggero June 17, 2020 19:56
@jamaljsr jamaljsr marked this pull request as ready for review June 17, 2020 19:56
@jamaljsr
Copy link
Member Author

This PR is ready for review. There are still a couple outstanding tweaks that are still waiting for approval before adding. I'd prefer to get all the completed fixes merged instead of waiting on the rest.

Copy link
Contributor

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great fixes! Tested on top of the lnd v0.10.2-beta.rc1 branch, going to build new RC3 binaries now.

@jamaljsr jamaljsr merged commit 571f365 into master Jun 18, 2020
@jamaljsr jamaljsr deleted the rc-feedback-fixes branch June 18, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants