itest: Extend custom channel liquidity itest for RFQ HTLC tracking #906
+191
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstadulis
changed the title
GeorgeTsagk
force-pushed
the
rfq-track-htlc-itests
branch
from
6b56147
to
f055328
Compare
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
7cb58a5
to
d82cb9d
Compare
|
@GeorgeTsagk do I only need to review the last three commits? |
GeorgeTsagk
force-pushed
the
rfq-track-htlc-itests
branch
from
f055328
to
e52a8c5
Compare
|
@ffranr this was just rebased, it's just one commit now (if you skip the temp one) |
ffranr
reviewed
Nov 27, 2024
Comment on lines
+2079
to
+2082
| // We set the waiting period for the slosh payment to occur. This is set | ||
| // to half of the default payment timeout, as we want it to occur half | ||
| // way through the in-flight payment. | ||
| sloshWait := PaymentTimeout / 3 |
Comment on lines
+2096
to
+2098
| // To avoid goroutine uncertainty, we wait as much as the above routine | ||
| // minus a small delta. This is enough for us to be sure that the | ||
| // payment will complete due to the slosh. |
There was a problem hiding this comment.
Is there a way to make this more events based driven? Instead of timing can we detect the arrival of HTLCs and respond when appropriate?
Comment on lines
+2102
to
+2125
| go func() { | ||
| // Now Charlie pays the invoice with assets. What happens on the | ||
| // Charlie-Dave channel doesn't matter. This payment will block | ||
| // until the previous slosh payment completes. That slosh will | ||
| // allow for the rest of the HTLCs to be forwarded. | ||
| payInvoiceWithAssets( | ||
| t.t, charlie, dave, invoiceResp.PaymentRequest, assetID, | ||
| true, defaultPaymentStatusOpt, | ||
| ) | ||
|
|
||
| done <- true | ||
| }() | ||
|
|
||
| select { | ||
| case <-done: | ||
| // If the payment completes before the slosh payment occurs then | ||
| // something went wrong, this is not the expected test case | ||
| // behavior. | ||
| t.Fatalf("payment completed before expected block period") | ||
| case <-timeoutChan: | ||
| // The expected time delay for the payment to complete has been | ||
| // passed, so now we wait for the payment to complete. | ||
| <-done | ||
| } |
There was a problem hiding this comment.
We have BeforeTimeout as a helper function. Would be good to have AfterTimestamp perhaps. But I think this sort of timing analysis strategy should be events driven instead.
|
|
||
| //nolint:lll | ||
| go func() { | ||
| // payInvoiceWithSatoshi(t.t, erin, iResp, lnrpc.Payment_FAILED) |
Comment on lines
+2196
to
+2199
| stream, err := erin.RouterClient.SendPaymentV2(ctxc, sendReq) | ||
| if err == nil { | ||
| _, _ = getPaymentResult(stream) | ||
| } |
There was a problem hiding this comment.
I think you should use this patter here:
stream, err := erin.RouterClient.SendPaymentV2(ctxc, sendReq)
require.NoError(t.t, err)
_, _ = getPaymentResult(stream)
Need error check on getPaymentResult result?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions
Adds an extra edge case to the custom channels itest which verifieds that the rfq htlc tracking mechanism works as expected.
Related tapd PR: lightninglabs/taproot-assets#1186