Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump demo apps to use lnc-rn to v0.3.1-alpha #41

Merged
merged 10 commits into from
Jul 30, 2024

Conversation

ViktorTigerstrom
Copy link
Contributor

Based on #40

This PR updates our demo apps to solve previous build errors, and also to use lnc-rn v0.3.1-alpha.

Note that this PR is currently in draft mode as lnc-rn v0.3.1-alpha is not yet released, and therefore uses local linking to add that version. This PR can be used to test #40 until it has been released. I'll update this PR with using the actual lnc-rn v0.3.1-alpha link once it has been released.

@ViktorTigerstrom ViktorTigerstrom force-pushed the 2024-02-demo-apps-lnc-rn-v0_3_1-alpha branch from 8a27794 to 830808b Compare February 26, 2024 19:04
@jamaljsr
Copy link
Member

After spending many hours trying to get 830808b to work on android, I was not successful. I couldn't get past the Inconsistent JVM-target compatibility detected for tasks 'compileDebugJavaWithJavac' (11) and 'compileDebugKotlin' (17). error. I even started down the path of creating new demo apps, but aborted mission once I realized that I'd need to update some of the Kotlin and Objective-C code to make it compatible with the latest react-native. That was going to turn into a big project.

After pulling my hair out for quite a while, I decided to try to restart from cb7d304 just to see if the NPM dependencies could be the source of the issues. Shockingly, it worked immediately with no changes! 🤯

I'm honestly not sure how or why this happened. The only changes I made to my system was to upgrade Android Studio to the latest version and wiped these dirs.

cd demos/connect-demo/
rm -rf node_modules/ android/.gradle/ ~/.gradle/ ios/Pods/ ios/build/

Surprisingly, the connect-demo didn't work on iOS back on this commit for some reason. It was working when I tested last week. I had to change the iOS target for React-Codegen to 12.4. I was also running into this error below. I found a fix for it here that worked for me and could be added to this PR.

image

So now I have connect-demo working on both iOS and Android using cb7d304. I'll test out the multi-connect-demo on both tomorrow.

@ViktorTigerstrom ViktorTigerstrom force-pushed the 2024-02-demo-apps-lnc-rn-v0_3_1-alpha branch from 830808b to e5ee87d Compare February 29, 2024 20:57
@ViktorTigerstrom ViktorTigerstrom marked this pull request as ready for review July 29, 2024 19:44
@ViktorTigerstrom ViktorTigerstrom force-pushed the 2024-02-demo-apps-lnc-rn-v0_3_1-alpha branch from e5ee87d to 9cc98bf Compare July 29, 2024 19:45
@ViktorTigerstrom ViktorTigerstrom force-pushed the 2024-02-demo-apps-lnc-rn-v0_3_1-alpha branch from 9cc98bf to 938e78e Compare July 29, 2024 20:58
@ViktorTigerstrom
Copy link
Contributor Author

Updated the PR to use the actual lnc-rn v0.3.1-alpha dependency that's now been released and removed the temp commits.

Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK LGTM 🚀

Thanks for the updates.

@ViktorTigerstrom ViktorTigerstrom merged commit 79657c7 into main Jul 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants