-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump demo apps to use lnc-rn
to v0.3.1-alpha
#41
Bump demo apps to use lnc-rn
to v0.3.1-alpha
#41
Conversation
8a27794
to
830808b
Compare
After spending many hours trying to get 830808b to work on android, I was not successful. I couldn't get past the After pulling my hair out for quite a while, I decided to try to restart from cb7d304 just to see if the NPM dependencies could be the source of the issues. Shockingly, it worked immediately with no changes! 🤯 I'm honestly not sure how or why this happened. The only changes I made to my system was to upgrade Android Studio to the latest version and wiped these dirs.
Surprisingly, the So now I have |
830808b
to
e5ee87d
Compare
Bump `react-native-gesture-handler` to `2.9.0` and `react-native-reanimated` to `v2.14.4`.
e5ee87d
to
9cc98bf
Compare
Bump `react-native-gesture-handler` to `2.9.0` and `react-native-reanimated` to `v2.14.4`.
9cc98bf
to
938e78e
Compare
Updated the PR to use the actual |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK LGTM 🚀
Thanks for the updates.
Based on #40
This PR updates our demo apps to solve previous build errors, and also to use
lnc-rn
v0.3.1-alpha
.Note that this PR is currently in draft mode as
lnc-rn
v0.3.1-alpha
is not yet released, and therefore uses local linking to add that version. This PR can be used to test #40 until it has been released. I'll update this PR with using the actuallnc-rn
v0.3.1-alpha
link once it has been released.