multi: add PSBT methods to wallet kit #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
commented
Jun 9, 2022
| @@ -868,6 +868,14 @@ | |||
| } | |||
| ] | |||
| }, | |||
| "/walletrpc.WalletKit/SignPsbt": { | |||
There was a problem hiding this comment.
The FundPsbt and FinalizePsbt methods were already here.
1 task
positiveblue
approved these changes
Jun 10, 2022
| return nil, nil, err | ||
| } | ||
|
|
||
| finalTx := wire.NewMsgTx(2) |
There was a problem hiding this comment.
out of scope for this PR but we may want to create some iota for the tx version?
There was a problem hiding this comment.
Hmm, it looks like we're only using it this way throughout the lnd codebase. But you're right, we should probably do it at some point :)
bhandras
approved these changes
Jun 10, 2022
| return nil, 0, nil, err | ||
| } | ||
|
|
||
| packet, err := psbt.NewFromRawBytes( |
There was a problem hiding this comment.
I suppose this is the kind of error that must never happen since otherwise the selected inputs will be locked forever?
There was a problem hiding this comment.
Yeah... Though the inputs wouldn't be locked forever, only 10 minutes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
in
lnd_services.goare updated.macaroon_recipes.goif your PR adds a new method that is calleddifferently than the RPC method it invokes.