Skip to content

signer: allow passing nil keyLocator to DeriveSharedKey #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

signer: allow passing nil keyLocator to DeriveSharedKey #226

merged 1 commit into from
Jun 11, 2025
+5 −2

Conversation

bhandras
Copy link
Member

Previously if the keyLocaltor argument was unset DeriveSharedKey would crash.

Pull Request Checklist

  • PR is opened against correct version branch.
  • Version compatibility matrix in the README and minimal required version
    in lnd_services.go are updated.
  • Update macaroon_recipes.go if your PR adds a new method that is called
    differently than the RPC method it invokes.

@bhandras
signer: allow passing nil keyLocator to DeriveSharedKey
aaf4f27 
Previously if the `keyLocaltor` argument was unset `DeriveSharedKey`
would crash.
@hieblmi hieblmi self-requested a review June 11, 2025 08:26
hieblmi
hieblmi approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@hieblmi hieblmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bhandras bhandras merged commit 0e5a2b0 into master Jun 11, 2025
1 check passed
@bhandras bhandras deleted the derivesharedkey-empty-keylocator branch June 11, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hieblmi hieblmi hieblmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhandras @hieblmi