Skip to content

lndclient: make notifier options exported (to help mocking) #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

lndclient: make notifier options exported (to help mocking) #231

merged 1 commit into from
Jul 1, 2025
+19 −19

Conversation

bhandras
Copy link
Member

Pull Request Checklist

  • PR is opened against correct version branch.
  • Version compatibility matrix in the README and minimal required version
    in lnd_services.go are updated.
  • Update macaroon_recipes.go if your PR adds a new method that is called
    differently than the RPC method it invokes.

@bhandras bhandras requested a review from starius June 30, 2025 15:44
starius
starius approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@starius starius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🏆

@guggero guggero merged commit a378c74 into master Jul 1, 2025
1 check passed
@guggero guggero deleted the exported-notifier-options branch July 1, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starius starius starius approved these changes

+1 more reviewer

@guggero guggero guggero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bhandras @starius @guggero