Skip to content

Conversation

@joostjager
Copy link
Contributor

No description provided.

Copy link
Contributor

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮
Nice to have this documented.


When breaking changes to the Loop client daemon API are made, old fields will be
marked as deprecated. Deprecated fields will remain supported until the next
minor release.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only the case as long as we are in the semver special case of major version 0. Afterwards breaking changes should only happen in major releases. Not sure if we should clarify this or if it's obvious to those who care.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we can change it if that happens. I am wondering why we don't just release major versions? There will always be improvements. @alexbosworth do you have an opinion on this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should do a major version as long as we have the -beta suffix. And as long as lnd (and LN in general) is considered beta (#reckless), we probably shouldn't give users the wrong sense of security by removing the -beta suffix in loop.
So probably no major releases for a few more years, IMO.

@joostjager joostjager merged commit dae3165 into lightninglabs:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants