Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cleared and confirmed timestamps to batches #170

Open
jamaljsr opened this issue Nov 20, 2020 · 2 comments
Open

Add cleared and confirmed timestamps to batches #170

jamaljsr opened this issue Nov 20, 2020 · 2 comments
Milestone

Comments

@jamaljsr
Copy link
Member

It would be useful to be able to obtain the timestamp that past batches were cleared on the server. This information is currently not possible to obtain. You can get a rough idea by querying a block explorer for the batch txid, seeing what block the tx is in and using the block's timestamp. This value will always be inaccurate since the batch tx is not guaranteed to be in the next block, it can be many blocks later if a low fee rate is used.

It would also useful to know the timestamp that a batch is confirmed on-chain in order to not have to query a block explorer as mentioned above.

@justinpobrien justinpobrien added this to the v0.3.4 milestone Nov 25, 2020
@halseth
Copy link
Contributor

halseth commented Feb 16, 2021

Fixed by #193 ?

@guggero
Copy link
Member

guggero commented Feb 16, 2021

No, the confirmed timestamp is still missing. That'll require more data to be added to the DB. Will probably be a bit easier once we've switched to using TLV in most places.

positiveblue pushed a commit to positiveblue/pool that referenced this issue Oct 11, 2022
venue: print out full list of offline traders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants