Allow distinct clearing price per lease duration bucket #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
force-pushed
the
duration-buckets
branch
2 times, most recently
from
2245fbf to
6940df3
Compare
|
I think this is ready for review now? |
|
Yes, has been for a while. |
halseth
suggested changes
Nov 24, 2020
guggero
force-pushed
the
duration-buckets
branch
4 times, most recently
from
60fc034 to
b830718
Compare
|
I was able to make everything non-breaking! |
wpaulino
reviewed
Nov 30, 2020
halseth
suggested changes
Dec 1, 2020
guggero
force-pushed
the
duration-buckets
branch
3 times, most recently
from
812fc13 to
37793f9
Compare
wpaulino
approved these changes
Dec 7, 2020
halseth
approved these changes
Dec 8, 2020
guggero
force-pushed
the
duration-buckets
branch
from
37793f9 to
47b3898
Compare
|
Rebased and addressed all comments. Even though this is ready to be merged now, I think we should wait until the server part is close to being merged as well. |
guggero
force-pushed
the
duration-buckets
branch
from
47b3898 to
32a51a3
Compare
guggero
force-pushed
the
duration-buckets
branch
from
32a51a3 to
fb68cd8
Compare
guggero
force-pushed
the
duration-buckets
branch
from
fb68cd8 to
f0d659c
Compare
guggero
force-pushed
the
duration-buckets
branch
2 times, most recently
from
b626b3d to
1ca3245
Compare
Because the batch Versions are in the order package, the use of order.DefaultVersion is confusing and not clear to be related to the version of the _batch_, just from its name. We fix that by renaming the versions of the batch.
Even though there still only is one batch version, we want to properly encode/decode it as a preparation for future version changes.
Because the order/lease duration is now governed by the lease durations, the maximum order duration is no longer needed.
We add a new order version that is allowed to submit lease durations outside of the default/legacy 2016 block duration. No new fields are added, so nothing changes in the serialization or the digest. This version only signals that the client is able to process batch requests with multiple duration buckets.
guggero
force-pushed
the
duration-buckets
branch
from
1ca3245 to
10c2ff1
Compare
|
Replaced by #199. |
positiveblue
pushed a commit
to positiveblue/pool
that referenced
this pull request
Oct 11, 2022
…tweak monitoring/dashboards: don't specify an explicit datasource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the client part of the change to switch over to distinct lease duration buckets for batches.
UPDATE: Made this non-breaking. Clients with batch version
0won't be able to submit orders with a lease duration != 2016.UPDATE2: Depends on #193 which was split off to make the server changes easier to split into multiple PRs.