Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: check dust outputs on account withdrawals and closures #150

Merged
merged 1 commit into from
Nov 12, 2020
Merged

rpc: check dust outputs on account withdrawals and closures #150

merged 1 commit into from
Nov 12, 2020

Conversation

wpaulino
Copy link
Contributor

@wpaulino wpaulino commented Nov 9, 2020

Prevents #146 from happening.

@wpaulino wpaulino requested review from halseth and Roasbeef November 9, 2020 22:38
rpcserver.go Outdated Show resolved Hide resolved
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥮

@wpaulino wpaulino requested a review from Roasbeef November 11, 2020 22:11
// account's value.
// With our account created, we'll start with an invalid withdrawal to a
// dust output, which should fail.
dustOutput := &wire.TxOut{Value: 0, PkScript: p2wsh}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@halseth halseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@halseth halseth merged commit 28bf7cd into lightninglabs:master Nov 12, 2020
@wpaulino wpaulino deleted the withdraw-output-dust-check branch November 13, 2020 00:29
positiveblue pushed a commit to positiveblue/pool that referenced this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants