server: fix REST connection #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halseth
reviewed
Nov 23, 2020
Roasbeef
approved these changes
Nov 24, 2020
| @@ -194,8 +195,8 @@ func (s *Server) Start() error { | |||
|
|
|||
| // We'll also create and start an accompanying proxy to serve | |||
| // clients through REST. | |||
| ctx, cancel := context.WithCancel(context.Background()) | |||
| defer cancel() | |||
|
@guggero Linter failing. Can merge once Travis pass. |
halseth
reviewed
Nov 24, 2020
If the REST listener is not nil at this point, it is always already wrapped in a TLS listener and doesn't need to be wrapped again.
Because of a misplaced defer of a context cancel, the REST proxy didn't work at all before the fix in this commit.
positiveblue
pushed a commit
to positiveblue/pool
that referenced
this pull request
Oct 11, 2022
Funding conflicts: Add auctioncli commands and track in Prometheus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of a misplaced defer of a context cancel, the REST proxy didn't
work at all before the fix in this commit.