rpc: delete previous pending batch after receiving replacement #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change was mostly motivated by the following scenario: 1. Trader accepts and signs a batch proposal, and stores it to disk. 2. Auctioneer send a new batch proposal due to another trader within the batch bailing out. 3. The trader who signed above rejects the new batch proposal. 4. The same trader attempts an account modification (deposit, withdrawal, renewal, etc.). 5. The spend handling logic as part of the account modification commits the staged batch proposal which was replaced, leaving the account state invalid. This is addressed by removing the staged batch proposal upon any replacements, regardless of whether they are accepted or not. This change also falls in line with the existing work done to clear any artifacts as the result of a previously accepted batch proposal.
positiveblue
pushed a commit
to positiveblue/pool
that referenced
this pull request
Oct 11, 2022
auctioneer test: ensure auctioneer shutdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was mostly motivated by the following scenario:
This is addressed by removing the staged batch proposal upon any replacements, regardless of whether they are accepted or not. This change also falls in line with the existing work done to clear any artifacts as the result of a previously accepted batch proposal.