Add new QuoteOrder RPC #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We port over the order quote calculation from the CLI to the order package so we can also offer the same calculation over RPC.
We create an RPC wrapper around the new order.NewQuote function with the goal of replacing the calculation that currently only exists in the CLI with an actual RPC call.
With the same order quote calculation now available as an RPC, we no longer need to do the calculation in the CLI code and can instead use the new QuoteOrder call.
wpaulino
approved these changes
May 6, 2021
|
Confirmed this RPC give me everything I need for the UI. Great work @guggero 🥇 |
positiveblue
pushed a commit
to positiveblue/pool
that referenced
this pull request
Oct 11, 2022
…buckets monitoring: use lesser set of exponentially increasing buckets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96.
Moves the order details/quote calculation from the CLI to a new RPC.
cc @jamaljsr.