Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update documentation #325

Merged
merged 1 commit into from
Dec 15, 2021
Merged

docs: update documentation #325

merged 1 commit into from
Dec 15, 2021

Conversation

positiveblue
Copy link
Contributor

I will add more documentation about supporting account auto renewal and client side account recovery after the changes for the client side recovery have been merged and we have a new tagged version.

Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 🎉

docs/faq.md Outdated
@@ -68,7 +72,7 @@ No. The channel behaves like a regular channel.

### What happens if the seller force closes a channel before the maturity date?

If the lender force closes they will be banned from the market. This will not be possible in the future.
Script level enforcement (WIP) will lock the maker's funds in the channel for the lease period. By now, we use a feature in `lnd` to prevent channels from being _cooperatively closed_ by the maker until the expiry height \(what we call the `thaw_height`\).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the WIP refer to this sentence or to the script level enforcement in general?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we do not have a way to enforce it yet right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR was merged and deployed, but you need to actively opt-in into script-enforced leases (if you're running lnd v0.14.x). So it's not WIP anymore, just not the default yet.

@positiveblue positiveblue merged commit 20f0c7b into master Dec 15, 2021
@guggero guggero deleted the update-docs branch December 15, 2021 11:30
positiveblue pushed a commit to positiveblue/pool that referenced this pull request Oct 11, 2022
multi: bump lnd, aperture and pool versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants