Add rpcserver test for RenewAccount endpoint
#326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
approved these changes
Dec 14, 2021
rpcserver_test.go
Outdated
| checkResponse func(*poolrpc.RenewAccountResponse) error | ||
| mockSetter func(*poolrpc.RenewAccountRequest, | ||
| *account.MockManager, *MockMarshaler, | ||
| ) |
There was a problem hiding this comment.
nit: closing parenthesis of method definition should be on same line as last argument (to better distinguish from method call). Same in the actual implementation below.
bhandras
approved these changes
Dec 14, 2021
order/interfaces.go
Outdated
| // Note: this matches the sha256.Size definition. However, mockgen | ||
| // complains about not being able to find the sha256 package. When | ||
| // that bug is fixed, we can change back to [sha256.Size]byte. | ||
| const size = 32 |
| @@ -123,7 +123,7 @@ type ManagerConfig struct { | |||
| } | |||
|
|
|||
| // Manager is responsible for the management of accounts on-chain. | |||
| type Manager struct { | |||
| type manager struct { | |||
There was a problem hiding this comment.
It's helpful to add a compile time enforcer for the interface:
var _ Manager = (*manager)(nil)
|
|
||
| resp, err := srv.RenewAccount(ctx, req) | ||
| if tc.expectedError != "" { | ||
| assert.EqualError(t, err, tc.expectedError) |
There was a problem hiding this comment.
nit: require and the expectation comes first iirc
There was a problem hiding this comment.
It looks like for EqualError this is the right order?
https://github.com/stretchr/testify/blob/master/assert/assertions.go#L1367
positiveblue
force-pushed
the
add-rpc-test
branch
2 times, most recently
from
0a6e92e to
9195066
Compare
The `mockgen` tool seems to have a bug and it is not able to parse a valid go file. I had to change the `[sha256.Size]byte` to `[size]byte` and define `hashSize` in the order package in the same way it is defined in the sha256 one.
The Marshaler interface is used to transform internal types to decorated RPC ones. It decouples that functionality form the rpcServer so it is easier to test exhaustively.
positiveblue
force-pushed
the
add-rpc-test
branch
from
9195066 to
ce0ba9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code extracted from #323 (removing the sponsoring part)