multi: remove static default channel types instead select them based on lnd's verison #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
positiveblue
approved these changes
Dec 17, 2021
guggero
requested changes
Dec 17, 2021
In this commit, we move to stop setting a default channel type on the CLI. Instead, we want this to be selected at runtime by the daemon based on what the lnd node can offer.
We'll use this in a follow up commit to decide what channel type we want to use.
In this commit, we add a new set of functional options that will allow the caller to pick an default channel type w/o forcing the main parse function to be aware of this logic.
In this commit, we use the prior commits to allow the server to dynamically select a channel type based on the lnd version.
Roasbeef
force-pushed
the
default-script-chan-type
branch
from
2c99c6f to
b413ace
Compare
positiveblue
approved these changes
Dec 22, 2021
|
The linter complains about the naming, will fix in separate PR. |
guggero
added a commit
to guggero/pool
that referenced
this pull request
Apr 11, 2022
To fix an accidental market segregation for lnd 0.14.x users that didn't set an explicit channel type in their bid orders, we roll back the changes from lightninglabs#330. We can re-enable this default value selection once a large number of ask orders support the new channel type.
positiveblue
pushed a commit
to positiveblue/pool
that referenced
this pull request
Oct 11, 2022
…aper-retry ratings: always reset the scrape time for the bos score scraper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we remove the defaults and the CLI and RPC level. We replace them with a new set of functional options that'll let us decide dynamically which features to use based on the lnd version. This lets us support older versions, while being able to activated newer features as we detect them based on what lnd offers.
Pull Request Checklist
used.