sidecar: Init mailbox after server restarts #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes #338 |
guggero
approved these changes
Feb 16, 2022
| @@ -314,6 +314,23 @@ func (a *SidecarNegotiator) autoSidecarReceiver(ctx context.Context, | |||
|
|
|||
| select { | |||
| case <-retryTimer.backOff(backoffLabel): | |||
| // It is possible that we were not able to receive the | |||
auto_sidecar.go
Outdated
| // packet because the server went down. In that case, | ||
| // we will try to init the sidecar mailbox again. | ||
| // There is no need to log/check this error. There are | ||
| // three possibilties: |
There was a problem hiding this comment.
nit: typo in possibilties (same below).
| // iteration. | ||
| // | ||
| // 3) If the server is down, we won't be able to reconnect. | ||
| _ = a.cfg.MailBox.InitAcctMailbox(streamID, acct.TraderKey) |
Whenever we are are unable to receive a sidecar packet in an auto sidecar negotiator try to init its mailbox. This will allow us to continue reading/writting in the mailbox in cases where the server went down and came back.
positiveblue
force-pushed
the
fix-issue-338
branch
from
e422051 to
ac3c44a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we are are unable to receive a sidecar packet in an auto
sidecar negotiator try to reinitialize its mailbox. This will allow us to
continue reading/writing in the mailbox in cases where the error was
caused by the server going down (and already came back).