sidecar: clean old shims for orders in current batch #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
approved these changes
Feb 25, 2022
| @@ -601,6 +601,13 @@ func (a *SidecarAcceptor) matchPrepare(pendingBatch *order.Batch, | |||
| sdcrLog.Infof("Received PrepareMsg for batch=%x, num_orders=%v", | |||
| batch.ID[:], len(batch.MatchedOrders)) | |||
|
|
|||
| // Ensure that we do not have any registered shims for the orders | |||
| // in this batch. This is not supposed to happen but we have a bug. | |||
| if err = a.removeShims(batch); err != nil { | |||
There was a problem hiding this comment.
Perhaps link to the PR where this will be fixed for good?
Also add a comment that removeShims will only return an error for serious problems (for example not being able to read orders from disk) and not if there is no pending shim (only a warning will be logged but no error returned).
positiveblue
pushed a commit
to positiveblue/pool
that referenced
this pull request
Oct 11, 2022
subastadb: fix empty SQL batch update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick (dirty) fix to ensure that we do not end up in an endless loop of batch rejections. One side effect is that we pollute the logs a bit more (issue #327).
#341 will fix this properly, by ensuring that shim creation after matching is atomic. Meanwhile this unblocks some of our traders.