mod: update lndclient to use new SignOutputRaw #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
approved these changes
Apr 1, 2022
| github.com/lightninglabs/aperture v0.1.17-beta.0.20220325093943-42b9d4c1be7f | ||
| github.com/lightninglabs/lndclient v0.15.0-0 | ||
| github.com/lightninglabs/aperture v0.1.17-beta.0.20220328072456-4a2632d0be38 | ||
| github.com/lightninglabs/lndclient v1.0.1-0.20220328143152-e7bebec99366 |
There was a problem hiding this comment.
I tried it before. I am not sure if I screwed up with the git tags, but if I use the v0.15.0-1 I get
➜ pool git:(signoutputraw) go mod tidy
go: finding module for package github.com/btcsuite/btcd/btcec
github.com/lightninglabs/pool imports
github.com/lightninglabs/lndclient imports
github.com/btcsuite/btcd/btcec: module github.com/btcsuite/btcd@latest found (v0.18.1), but does not contain package github.com/btcsuite/btcd/btcec
There was a problem hiding this comment.
Okay, there was something very weird with that tag... Created a new one (v0.15.0-2) and it seems to work now.
bhandras
approved these changes
Apr 1, 2022
|
Next steps:
|
positiveblue
pushed a commit
to positiveblue/pool
that referenced
this pull request
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not using taproot txs yet so we can just leave the new param to
nil