rpcserver: fix recoveryPending attribute
#355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
positiveblue
changed the title
recoveryPending atrib.recoveryPending attribute
guggero
approved these changes
Apr 12, 2022
| s.recoveryPending = true | ||
| // Mark the recovery process as done whenever we finish. |
There was a problem hiding this comment.
Should we move this whole block just one line down, so it's after the Unlock()? That way it's a bit easier to reason about whether this could lead to a deadlock or not (in case you miss the defer when scanning the code linearly).
There was a problem hiding this comment.
Sorry, my comment was a bit inaccurate. But the s.recoveryPending = true should still be within the lock.
bhandras
approved these changes
Apr 12, 2022
| @@ -1148,10 +1148,17 @@ func (s *rpcServer) RecoverAccounts(ctx context.Context, | |||
|
|
|||
| s.recoveryMutex.Lock() | |||
| if s.recoveryPending { | |||
| defer s.recoveryMutex.Unlock() | |||
| s.recoveryMutex.Unlock() | |||
There was a problem hiding this comment.
nit: alternatively we could just use an atomic int to avoid the (slightly complex) locking logic.
positiveblue
force-pushed
the
account-recover-fix
branch
from
72386eb to
973e7d0
Compare
The rpcserver cannot have more than one account recovery process running at once. The server uses a internal attribute (`recoveryPending`) that is set to true when a new recovery process starts. However, that attribute was only set to false if the process ended successfully, leaving the server unable to try more recoveries after a failure.
positiveblue
force-pushed
the
account-recover-fix
branch
from
973e7d0 to
777dce5
Compare
positiveblue
pushed a commit
to positiveblue/pool
that referenced
this pull request
Oct 11, 2022
Admin RPC Financial Report endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rpcserver cannot have more than one account recovery process running
at once. The server uses a internal attribute (
recoveryPending) thatis set to true when a new recovery process starts. However, that
attribute was only set to false if the process ended successfully,
leaving the server unable to try more recoveries after a failure.