Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forgotten server account state #369

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Add forgotten server account state #369

merged 2 commits into from
Jun 9, 2022

Conversation

guggero
Copy link
Member

@guggero guggero commented Jun 8, 2022

We add a state that existed on the server side for a while but we never exposed on the RPC level.

We'll push a new tag auctioneerrpc/v1.0.7 after this PR is merged.

Pull Request Checklist

  • LndServices minimum version has been updated if new lnd apis/fields are
    used.

@guggero guggero requested a review from positiveblue June 8, 2022 10:42
positiveblue
positiveblue approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@positiveblue positiveblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I wonder if there is a tool for checking this things (that we have the relative field in a proto for a iota in Go) 👀

@guggero guggero merged commit 19eed44 into master Jun 9, 2022
@guggero guggero deleted the server-account-state branch June 9, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@positiveblue positiveblue positiveblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guggero @positiveblue