Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, improve trace logging #376

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Update dependencies, improve trace logging #376

merged 2 commits into from
Jun 20, 2022

Conversation

guggero
Copy link
Member

@guggero guggero commented Jun 17, 2022

With this PR we update to the latest dependencies (same commit from #370, assuming this one gets in first) and improve the trace logging around the messages being sent to and from the server.

Pull Request Checklist

  • LndServices minimum version has been updated if new lnd apis/fields are
    used.

@guggero guggero requested a review from positiveblue June 17, 2022 12:53
@guggero guggero marked this pull request as ready for review June 17, 2022 12:53
Copy link
Contributor

@positiveblue positiveblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


// PrintMsg prints a protobuf message as JSON, suitable for logging (without any
// indentation).
func PrintMsg(message proto.Message) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@guggero guggero merged commit 76bac18 into master Jun 20, 2022
@guggero guggero deleted the better-logging branch June 20, 2022 07:48
positiveblue pushed a commit to positiveblue/pool that referenced this pull request Oct 11, 2022
…ection

Use etcd for leader election to orchestrate multiple subasta instances running at once
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants