Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account: transaction labels code cleanup #413

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Nov 7, 2022

PR #396 was merged prematurely. This PR addresses any remaining review comments.

Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes. Looks good, just one small issue.

account/manager.go Outdated Show resolved Hide resolved
@ffranr ffranr force-pushed the cleanup_account_tx_labels branch from 1c6966d to 2679396 Compare November 7, 2022 12:53
@ffranr ffranr requested a review from guggero November 7, 2022 12:54
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@guggero
Copy link
Member

guggero commented Nov 7, 2022

Trivial diff, going to merge with just a single review.

@guggero guggero merged commit 037d467 into lightninglabs:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants