Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: perform dependencies installation in separate run layer #419

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Nov 15, 2022

This commit separates the task of dependencies installation into its own separate run layer. Previously, dependencies installation shared the same layer as local repo build.

This change means that the dependencies run layer can be reused (cached) whilst the local repo is modified. Which is helpful for regtests.

I've tested this change by building the docker image.

Pull Request Checklist

  • LndServices minimum version has been updated if new lnd apis/fields are
    used.

This commit separates the task of dependencies installation into its own separate run layer. Previously, dependencies installation shared the same layer as local repo build.

This change means that the dependencies run layer can be reused (cached) whilst the local repo is modified. Which is helpful for regtests.
@ffranr ffranr requested a review from guggero November 15, 2022 14:47
@guggero guggero merged commit ef9dd9a into lightninglabs:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants