Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: configurable RequestShutdown call-back in config #421

Merged

Conversation

ellemouton
Copy link
Member

@ellemouton ellemouton commented Dec 2, 2022

Add RequestShutdown option to Pool's config that callers running pool as a subserver can set to whatever they want. By default the function will be a no-op. In the case where Pool is running as a standalone binary, the call-backs will call the corresponding signal interceptor function.

@ellemouton ellemouton force-pushed the allowCustomRequestShutdownFunc branch from 53d2d66 to 7d61099 Compare December 2, 2022 15:45
@ellemouton ellemouton changed the title multi: configurable RequestShutdown and ShutdownChannel funcs multi: configurable RequestShutdown call-back in config Dec 2, 2022
@ellemouton ellemouton force-pushed the allowCustomRequestShutdownFunc branch from 7d61099 to 7a9c7be Compare December 2, 2022 15:48
Copy link
Contributor

@positiveblue positiveblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

We can rethink in the future a better default behaivour for when it runs as a sub server (so we do not have critical errors that should make the app stop being totally ignored)

@positiveblue positiveblue merged commit aec0aee into lightninglabs:master Dec 2, 2022
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post merge ACK 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants