Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter problems #441

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Fix linter problems #441

merged 3 commits into from
Feb 24, 2023

Conversation

guggero
Copy link
Member

@guggero guggero commented Feb 23, 2023

Discovered by #440, looks like the linter doesn't run anymore.

Pull Request Checklist

  • LndServices minimum version has been updated if new lnd apis/fields are
    used.

It looks like one of the projects pulled in by the linter also uses the
"tools" build tag. When we turn on that build tag, we get build errors
in github.com/ryancurrah/gomodguard. So we just remove the build tag
during compilation as it's not actually needed (the build tag is just
there to not pull in the dependencies during the normal build).
rpcserver_test.go Show resolved Hide resolved
Copy link
Contributor

@ffranr ffranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 💯

@guggero guggero merged commit d33863f into lightninglabs:master Feb 24, 2023
@guggero guggero deleted the linter-fix branch February 24, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants