Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: specify gRPC keepalive params #457

Merged
merged 2 commits into from
Jun 5, 2023
Merged

server: specify gRPC keepalive params #457

merged 2 commits into from
Jun 5, 2023

Conversation

guggero
Copy link
Member

@guggero guggero commented Jun 5, 2023

With this commit we instruct the gRPC client to ping the server every 10 seconds to make sure the TCP connection is still alive.

Tested with Wireshark.

Pull Request Checklist

  • LndServices minimum version has been updated if new lnd apis/fields are
    used.

@guggero guggero requested review from positiveblue and ffranr June 5, 2023 09:02
@guggero guggero mentioned this pull request Jun 5, 2023
Merged
positiveblue
positiveblue approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@positiveblue positiveblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ffranr
ffranr approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@ffranr ffranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⌛ Nice! ⌚

server.go Outdated Show resolved Hide resolved
@guggero
server: specify gRPC keepalive params
4ccc703 
With this commit we instruct the gRPC client to ping the server every 10
seconds to make sure the TCP connection is still alive.
@positiveblue positiveblue merged commit e5d6a5f into lightninglabs:master Jun 5, 2023
@guggero guggero deleted the client-ping branch June 5, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffranr ffranr ffranr approved these changes

@positiveblue positiveblue positiveblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guggero @positiveblue @ffranr