Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass 'pkg' argument to flake-unit-race Makefile target #1044

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

gijswijs
Copy link
Contributor

This PR changes the behavior of the target flake-unit-race in the Makefile, to allow to run it for a specific package continuously.

Usage example: 'make flake-unit-race pkg=tapgarden'

Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, LGTM 🎉

Makefile Outdated Show resolved Hide resolved
make/testing_flags.mk Outdated Show resolved Hide resolved
This commit changes the behavior of the target `flake-unit-race` in the
Makefile, to allow to run it for a specific package continuously.

Usage example: 'make flake-unit-race pkg=tapgarden'
@gijswijs gijswijs force-pushed the flake-unit-race-pkg branch from 9e92b52 to b3a0095 Compare July 25, 2024 15:09
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like the new approach. re-ACK 🎉

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Roasbeef Roasbeef added this pull request to the merge queue Jul 29, 2024
Merged via the queue into main with commit f0aaf17 Jul 29, 2024
16 checks passed
@guggero guggero deleted the flake-unit-race-pkg branch July 29, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants