Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: specify proof courier proof recipient at delivery or receive #1088

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Aug 15, 2024

Related to #1082

This commit enables establishing a connection to a proof courier service without specifying a particular recipient (proof owner). This change allows us to:

  • Share proof courier service connections among multiple recipient peers.

  • Test connections to the proof courier service earlier in the process, before the proof owner recipient is specified. This test can now occur before the anchor transaction broadcast in the ChainPorter's state machine.

@ffranr ffranr self-assigned this Aug 15, 2024
@coveralls
Copy link

coveralls commented Aug 15, 2024

Pull Request Test Coverage Report for Build 10407664036

Details

  • 10 of 34 (29.41%) changed or added relevant lines in 5 files are covered.
  • 24 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.007%) to 40.173%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tapchannel/aux_sweeper.go 0 7 0.0%
tapfreighter/chain_porter.go 0 7 0.0%
proof/courier.go 1 11 9.09%
Files with Coverage Reduction New Missed Lines %
tapdb/addrs.go 2 79.04%
tappsbt/create.go 2 53.85%
asset/asset.go 2 81.54%
tapgarden/caretaker.go 4 68.5%
commitment/tap.go 5 84.17%
universe/interface.go 9 47.09%
Totals Coverage Status
Change from base Build 10406522886: -0.007%
Covered Lines: 23688
Relevant Lines: 58965

💛 - Coveralls

@dstadulis dstadulis added this to the v0.4.2 milestone Aug 15, 2024
@ffranr ffranr requested review from jharveyb and guggero August 15, 2024 15:56
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 🎉

proof/courier.go Outdated Show resolved Hide resolved
This commit enables establishing a connection to a proof courier service
without specifying a particular recipient (proof owner). This change
allows us to:

* Share proof courier service connections among multiple recipient
  peers.

* Test connections to the proof courier service earlier in the process,
  before the proof owner recipient is specified. This test can now occur
  before the anchor transaction broadcast in the ChainPorter's state
  machine.
@ffranr ffranr force-pushed the share-proof-courier-con branch from d79c4af to 764ef38 Compare August 15, 2024 17:14
Copy link
Contributor

@jharveyb jharveyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch 👍🏽

IIUC this change doesn't add any connection sharing? But I figure that'll come as a follow-up.

@ffranr ffranr added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit 0a64116 Aug 16, 2024
17 checks passed
@guggero guggero deleted the share-proof-courier-con branch August 19, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants