Refactor FederationEnvoy.AddServer connection logic and add unit tests
#1800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the InsertUniverseServer SQL query with UpsertUniverseServer. Since adding a server that already exists is harmless, we use an upsert to avoid handling unique constraint errors at call sites.
Move the server connection check into `FederationEnvoy.AddServer`, simplifying the logic at two call sites. The method now returns a `ServerAddReport` for each candidate server. This report includes whether the server was already known, and whether the connection check was attempted and succeeded/failed.
Add unit tests and supporting mock functionality to provide test coverage for the `FederationEnvoy.AddServer` method, which previously had none.
Pull Request Test Coverage Report for Build 17771102876Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
FederationEnvoy.AddServermethod by:AddServer, simplifying logic at two call sites.ServerAddReportstruct that provides detailed feedback on each server addition attempt (e.g., whether it was already known and the result of the connection check).AddServer, which previously had none.Also includes:
UpsertUniverseServerin place ofInsertUniverseServer, avoiding unique constraint errors when adding known servers.