Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proof: add magic bytes to individual proofs and proof files #488

Merged
merged 4 commits into from
Sep 8, 2023
Merged

proof: add magic bytes to individual proofs and proof files #488

merged 4 commits into from
Sep 8, 2023

Conversation

guggero
Copy link
Member

@guggero guggero commented Sep 6, 2023

Fixes #402.

ffranr
ffranr reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@ffranr ffranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this change, thank you!

proof/proof_test.go Show resolved Hide resolved
rpcserver.go Outdated Show resolved Hide resolved
rpcserver.go Outdated Show resolved Hide resolved
rpcserver.go Outdated Show resolved Hide resolved
taprpc/assetwalletrpc/assetwallet.swagger.json Outdated Show resolved Hide resolved
taprpc/taprootassets.proto Outdated Show resolved Hide resolved
taprpc/taprootassets.proto Outdated Show resolved Hide resolved
taprpc/taprootassets.proto Outdated Show resolved Hide resolved
ffranr
ffranr reviewed Sep 6, 2023
View reviewed changes
rpcserver.go Show resolved Hide resolved
@guggero guggero requested a review from ffranr September 7, 2023 07:41
@ffranr
Copy link
Contributor

ffranr commented Sep 7, 2023 •
edited
Loading

Postgres itest failed in CI, I've re-run.

EDIT: and it's failed again with:

2023-09-07 13:08:59.719 [INF] TADB: Connecting to Postgres fixture: ***localhost:32828/test?sslmode=disable

ffranr
ffranr approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@ffranr ffranr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

(CI fail doesn't seem to be because of these changes.)

@guggero
Copy link
Member Author

guggero commented Sep 7, 2023

Postgres itest failed in CI, I've re-run.

EDIT: and it's failed again with:

2023-09-07 13:08:59.719 [INF] TADB: Connecting to Postgres fixture: ***localhost:32828/test?sslmode=disable

Yeah, the postgres itest failure is really weird. It looks like the process is just killed after some time. Sounds like an issue with the GitHub environment. Maybe we're using too much memory? I'll try to investigate. Here's something I found: Lightning-Universe/lightning-bolts#409

jharveyb
jharveyb approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@jharveyb jharveyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have this feature and make the RPC & CLI more consistent! + unblock builders

rpcserver.go Show resolved Hide resolved
@guggero guggero added this pull request to the merge queue Sep 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 8, 2023
@guggero guggero added this pull request to the merge queue Sep 8, 2023
Merged via the queue into main with commit c5bdbfe Sep 8, 2023
14 checks passed
@guggero guggero deleted the proof-magic-bytes branch September 8, 2023 14:43
@guggero guggero mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffranr ffranr ffranr approved these changes

@jharveyb jharveyb jharveyb approved these changes

Assignees

@guggero guggero

Labels
burning proofs
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proof: add a set of magic bytes to the serialized proof file format
4 participants
@guggero @ffranr @jharveyb @dstadulis