Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-input PSBT spend for homogeneous input asset ID #743

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Dec 19, 2023

This PR solves #297 for the case were each input asset ID is the same.

This PR modifies our asset send procedure such that we can spend a multi-input full value PSBT where each input has the same asset ID. The PR adds an itest to test the new changes.

There are more things we should test:

  • more than 2 inputs
  • sending the received PSBT spend onwards once more.

But lets keep this PR small if we can and open another (if that makes sense).

This PR replaces #741
I've moved the branch to repo lightninglabs/taproot-assets so that I can base another branch on top of it.

Fixes #297

In this commit we modify the `AnchorVirtualPsbts` RPC endpoint to enable
support for multi-input vPSBT.
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-ACK on new PR, LGTM 🎉

tapscript/send.go Outdated Show resolved Hide resolved
This commit adds support for multi-input full value interactive send
where each input asset shares the same asset ID.
This commit adds a tests to ensure that we can correctly construct and
spend a multi-input full value PSBT where each input has the same asset
ID.
Copy link
Contributor

@jharveyb jharveyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid send improvements, LGTM 🎉

@guggero guggero added this pull request to the merge queue Dec 20, 2023
Merged via the queue into main with commit c61d19f Dec 20, 2023
14 checks passed
@guggero guggero deleted the anchorvp-multi-inputs branch December 20, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add full-value multi-input homogeneous asset IDs support to RPC endpoint AnchorVirtualPsbts
4 participants