node_announcements are sent in format violation of BOLT 7

[TheBlueMatt]

BOLT 7 states:
"The origin node:...MUST NOT include more than one address descriptor of the same type.", however, lnd happily relays along such node announcements (see, eg, the node with alias "BallLightning" which has two IPv4 entires).

[githorray]

$ lncli getnodeinfo 02b813dcf53442e2ba8ac0b7911dc31ab0b62fda5e55b30388efb6c39a8ee54d3c
{
    "node": {
        "last_update": 1523630651,
        "pub_key": "02b813dcf53442e2ba8ac0b7911dc31ab0b62fda5e55b30388efb6c39a8ee54d3c",
        "alias": "BallLightning",
        "addresses": [
            {
                "network": "tcp",
                "addr": "76.93.137.43:9735"
            },
            {
                "network": "tcp",
                "addr": "76.176.5.137:9735"
            }
        ],
        "color": "#ff0000"
    },
    "num_channels": 1,
    "total_capacity": "200000"
}

$ lncli getnodeinfo 03baa70886d9200af0ffbd3f9e18d96008331c858456b16e3a9b41e735c6208fef
{
    "node": {
        "last_update": 1529038762,
        "pub_key": "03baa70886d9200af0ffbd3f9e18d96008331c858456b16e3a9b41e735c6208fef",
        "alias": "LIGHTNING",
        "addresses": [
            {
                "network": "tcp",
                "addr": "45.20.67.1:9735"
            },
            {
                "network": "tcp",
                "addr": "[2001:470:8:2e1::43]:9735"
            },
            {
                "network": "tcp",
                "addr": "[2001:470:8:2e1::43]:9735"
            }
        ],
        "color": "#03baa7"
    },
    "num_channels": 12,
    "total_capacity": "2471554"
}

[Saibato]

@Roasbeef @TheBlueMatt
I think about to change the following line in BOLT-7
MUST NOT include more than 21 address descriptor.
lightning/bolts@2719d87

[Roasbeef]

Based on the above and my reading of the current spec, it seems this is allowed.

[TheBlueMatt]

Indeed, fixed by lightning/bolts#751