Witness_Type in 2 packages diverged

[ziggie1984]

We have the variable witness_type in 2 places but they divereged: input/witnessgen.go and in walletrpc.proto
I want to bring them back to unity and was also thinking of using the same order(same enum value) in both, which makes it easier to compare. Or are types only appended in the protofiles and never rearrange because of backwards compatibility (which shouldn't be a problem IMO)

I found out about it when sweeping a TX:
lncli wallet pendingsweeps showed me: UNKNOWN_WITNESS

But the log was also clear about it:
2023-02-26 16:39:32.956 [WRN] WLKT: Unhandled witness type HtlcOfferedTimeoutSecondLevelInputConfirmed for input e7a90e891c56b5a3fea4977a161aa1be77f4cee4977c6112ea410d3ac01a2761:4

Feel free to assign it to me, if we wanna fix this.

[guggero]

Makes sense to get them re-aligned. I think we should add a comment in input/witnessgen.go that these enum values are used in gRPC so we don't forget to update the RPC enum. Or maybe add a test that detects divergences?

[emilioziniades]

Hi there, I'd like to give this a go.

I'll realign them, add a comment and write a test to detect divergence

[ziggie1984]

Sounds good, have fun :)

[emilioziniades]

Hey @guggero, I've made some progress on a PR for this issue, would you mind having a look please?