routing: probability based path finding #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostjager
changed the title
joostjager
force-pushed
the
probability
branch
3 times, most recently
from
959d3c9 to
993fc3e
Compare
joostjager
changed the title
joostjager
force-pushed
the
probability
branch
4 times, most recently
from
01ca7e2 to
7fec889
Compare
Roasbeef
added
P2
joostjager
changed the title
joostjager
force-pushed
the
probability
branch
2 times, most recently
from
3caaec0 to
ae2bdfd
Compare
halseth
reviewed
May 10, 2019
routing/missioncontrol.go
Outdated
| } | ||
| } | ||
|
|
||
| // If we are still in the hard prune window, return probability 0. |
There was a problem hiding this comment.
could we consider letting this happen, and instead rely on the payment timing out instead? That would allow long-lived path finding.
There was a problem hiding this comment.
Changed this part of the PR. Currently mission control isn't concerned with 'hard pruning' anymore. Instead, a minimum probability restriction is added to path finding. Setting this to a low value should help prevent trying unlikely routes in a short loop.
There was a problem hiding this comment.
For long payment timeouts it may actually be desired that we go over previously failed routes again to see if conditions improved.
joostjager
force-pushed
the
probability
branch
3 times, most recently
from
f483fe2 to
6dea767
Compare
|
ptal @halseth |
joostjager
force-pushed
the
probability
branch
3 times, most recently
from
ca52413 to
1c20823
Compare
halseth
reviewed
Jun 4, 2019
This commit ensures that channel endpoints in EdgeInfo are ordered node1 < node2 to not violate assumptions being made by dependent code.
This function is only ever called for channels connected to self.
This PR replaces the previously used edge and node ignore lists in path finding by a probability based system. It modifies path finding so that it not only compares routes on fee and time lock, but also takes route success probability into account. Allowing routes to be compared based on success probability is achieved by introducing a 'virtual' cost of a payment attempt and using that to translate probability into another cost factor.
This commit adds a new restriction to pathfinding that allows returning only routes with a minimum success probability.
Previously every payment had its own local mission control state which was in effect only for that payment. In this commit most of the local state is removed and payments all tap into the global mission control probability estimator. Furthermore the decay time of pruned edges and nodes is extended, so that observations about the network can better benefit future payment processes. Last, the probability function is transformed from a binary output to a gradual curve, allowing for a better trade off between candidate routes.
This commit exposes mission control state for rpc for development purposes.
Adds querymc command to lncli to dump mission control state.
|
@halseth ptal |
This commit exposes the three main parameters that influence mission control and path finding to the user as command line or config file flags. It allows for fine-tuning for optimal results.
halseth
approved these changes
Jun 5, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, several improvements to path finding and mission control are made with the goal to improve the reliability of Lightning payments.
Changes
Probability based routing
The previously used edge and node ignore lists in path finding are replaced by a probability based system. It modifies path finding so that it not only compares routes on fee and time lock, but also takes route success probability into account.
Allowing routes to be compared based on success probability is achieved by introducing a 'virtual' cost of a payment attempt and using that to translate probability into an extra cost factor.
Failed route decay time
This PR also extends the decay time of mission control data. It used to be very short which hardly allowed a payment to benefit from outcomes of previous payment attempts. With this PR, the decay time becomes configurable.
Minimum route probability
The payment process stop condition has been adapted to probability based routing. Previously the payment processed stopped when no more routes could be found. This typically happened when all tried edges had been added to the ignore list. With probabilities, every route will always have a non-zero success probability. That probability can be small, but the payment may still succeed via this route.
To prevent the payment process ending up in a loop trying routes that are highly unlikely to succeed until it times out, a minimum required success probability is introduced. Only routes with a probability above this threshold are considered and if there are none, the payment process is stopped.
Query mission control state
A new rpc call has been added to query the internal mission control state. This should give advanced users a tool to better understand why certain routes are chosen.
Usage
Config
The main parameters influencing the payment process within
lndare exposed as command line or config flags. For these flags to be available,lndneeds to be build withtags="routerrpc".--routerrpc.minrtprob=Minimum required route success probability to attempt the payment (default: 0.01)
--routerrpc.apriorihopprob=Assumed success probability of a hop in a route when no other information is available. (default: 0.95)
--routerrpc.penaltyhalflife=Defines the duration in minutes after which a penalized node or channel is back at 50% probability (default: 60)
--routerrpc.attemptcost=The (virtual) cost in sats of a failed payment attempt (default: 100)
lncli
Querying mission control is available through
lncli(also requiring therouterrpctag):lncli querymc