routerrpc: share payment parsing code from main rpc #2821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostjager
force-pushed
the
payment-rpc
branch
3 times, most recently
from
ab92bc9
to
585185b
Compare
joostjager
changed the title
joostjager
changed the title
joostjager
force-pushed
the
payment-rpc
branch
2 times, most recently
from
aed2af2
to
0d2591a
Compare
Roasbeef
added
payments
|
Closing this PR, because the new API introduced in #2973 is too different from the existing one to benefit from code reuse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a preparation for the new reliable send payment rpc in routerrpc.
Last debug commit will be dropped after review.