sweep+rpc+cmd/lncli: expose pending input sweeps over RPC + CLI #3089

wpaulino · 2019-05-17T03:02:31Z

In this PR, we expose the set of pending inputs that the UtxoSweeper is currently attempting to sweep. This will serve as preparatory work for allowing users to perform fee bumps. Due to the UtxoSweeper's asynchronous nature, we are not able to quickly report on whether a fee bump succeeded or not, so we resort towards exposing its internal fee rate bucketing system over RPC to give users an indication of what's currently being swept and with what fee rate.

I opted to only expose the sweeping fee rate for each bucket, along with all of the inputs within each bucket and their individual fee rates for now. Looking for feedback on whether we could be exposing this information better.

Depends on #3026.

sweep/sweeper.go

wpaulino · 2019-05-17T23:33:01Z

PTAL @joostjager.

lnrpc/invoicesrpc/invoices.pb.go

lnrpc/rpc.proto

rpcserver.go

sweep/sweeper.go

Roasbeef

Looks pretty good, just a few cosmetics related comments

Roasbeef · 2019-05-25T01:09:08Z

lnrpc/rpc.proto

+    sweep transaction of the output.
+    */
+    uint32 next_broadcast_height = 6 [json_name = "next_broadcast_height"];
+}


Once we circle back and add retargeting, it may be useful to expose what the next fee rate would be.

rpcserver.go

cmd/lncli/types.go

sweep/sweeper.go

joostjager · 2019-05-28T08:27:38Z

sweep/sweeper.go

+	for _, pendingInput := range s.pendingInputs {
+		// Only the exported fields are set, as we expect the response
+		// to only be consumed externally.
+		pendingInputs = append(pendingInputs, &PendingInput{


I had the same thing with creating a snapshot in mission control and introduced separate exported structs for the snapshot. I think it is cleaner. (non blocking)

Yeah that was how the initial design of the PR approached it, but I opted for reusing the same struct to result in less code, though the difference is not much.

Roasbeef

Tested locally, works as advertised!

LGTM contingent in unifying the byte reversal (in lncli as we do elsewhere) 🌊

cfromknecht

straightforward diff, some high level comments

lnrpc/rpc.swagger.json

rpcserver.go

cfromknecht · 2019-06-01T00:25:23Z

@wpaulino needs rebase

cmd/lncli/types.go

rpcserver.go

sweep/sweeper.go

wpaulino · 2019-06-05T00:44:45Z

PTAL @Roasbeef @joostjager.

joostjager

Tested and found that it works. Only minor comment is that the field name sat_per_byte remains a little vague without reading the comment. But don't know if last_sat_per_byte would be any better.

This will serve useful when exposing the pending inputs over RPC, since we currently don't keep track of the last fee rate used for an input.

wpaulino · 2019-06-05T19:11:10Z

Only minor comment is that the field name sat_per_byte remains a little vague without reading the comment.

Agreed. This is why bitcoin-cli also includes a description of the command's response. Possibly something we can look into later down the road.

Rebased to address a cmd/lncli conflict.

cfromknecht

LGTM ✅

cmd/lncli/types.go

wpaulino requested a review from joostjager May 17, 2019 03:02

wpaulino added utxo sweeping cli Related to the command line interface enhancement Improvements to existing features / behaviour fees Related to the fees paid for transactions (both LN and funding/commitment transactions) rpc Related to the RPC interface labels May 17, 2019

joostjager reviewed May 17, 2019

View reviewed changes

sweep/sweeper.go Show resolved Hide resolved

sweep/sweeper.go Outdated Show resolved Hide resolved

sweep/sweeper.go Outdated Show resolved Hide resolved

wpaulino force-pushed the pendingsweeps-rpc branch from dd7a59c to 394bd91 Compare May 17, 2019 23:28

wpaulino added this to the 0.7 milestone May 17, 2019

wpaulino force-pushed the pendingsweeps-rpc branch from 394bd91 to 6ec7bb9 Compare May 18, 2019 02:53

wpaulino requested a review from Roasbeef May 18, 2019 02:53

joostjager reviewed May 20, 2019

View reviewed changes

lnrpc/invoicesrpc/invoices.pb.go Outdated Show resolved Hide resolved

lnrpc/rpc.proto Outdated Show resolved Hide resolved

rpcserver.go Outdated Show resolved Hide resolved

sweep/sweeper.go Outdated Show resolved Hide resolved

wpaulino force-pushed the pendingsweeps-rpc branch from 6ec7bb9 to 9118e3c Compare May 22, 2019 03:13

joostjager reviewed May 22, 2019

View reviewed changes

sweep/sweeper.go Outdated Show resolved Hide resolved

wpaulino force-pushed the pendingsweeps-rpc branch from 9118e3c to 9fd0c47 Compare May 23, 2019 02:08

Roasbeef requested changes May 25, 2019

View reviewed changes

joostjager reviewed May 27, 2019

View reviewed changes

sweep/sweeper.go Outdated Show resolved Hide resolved

wpaulino force-pushed the pendingsweeps-rpc branch from 9fd0c47 to 22b401b Compare May 27, 2019 23:38

wpaulino commented May 27, 2019

View reviewed changes

sweep/sweeper.go Outdated Show resolved Hide resolved

joostjager reviewed May 28, 2019

View reviewed changes

wpaulino force-pushed the pendingsweeps-rpc branch from 22b401b to 1c340b9 Compare May 28, 2019 23:05

Roasbeef approved these changes May 29, 2019

View reviewed changes

wpaulino force-pushed the pendingsweeps-rpc branch from 1c340b9 to cfcc0b9 Compare May 29, 2019 00:13

cfromknecht reviewed May 29, 2019

View reviewed changes

lnrpc/rpc.swagger.json Outdated Show resolved Hide resolved

rpcserver.go Outdated Show resolved Hide resolved

wpaulino force-pushed the pendingsweeps-rpc branch from cfcc0b9 to 0b6541a Compare May 29, 2019 00:36

wpaulino mentioned this pull request May 29, 2019

sweep+rpc: add support to bump fee of inputs/transactions #3140

Merged

cfromknecht reviewed Jun 1, 2019

View reviewed changes

cmd/lncli/types.go Show resolved Hide resolved

wpaulino force-pushed the pendingsweeps-rpc branch from 0b6541a to 70b32d5 Compare June 1, 2019 00:32

wpaulino force-pushed the pendingsweeps-rpc branch from 70b32d5 to 0c525ca Compare June 3, 2019 23:32

joostjager reviewed Jun 4, 2019

View reviewed changes

rpcserver.go Outdated Show resolved Hide resolved

sweep/sweeper.go Outdated Show resolved Hide resolved

wpaulino force-pushed the pendingsweeps-rpc branch from 0c525ca to fcb0467 Compare June 4, 2019 23:24

joostjager approved these changes Jun 5, 2019

View reviewed changes

wpaulino added 3 commits June 5, 2019 12:10

sweep: add lastFeeRate field to PendingInput

50a8f18

This will serve useful when exposing the pending inputs over RPC, since we currently don't keep track of the last fee rate used for an input.

sweep: expose pending input sweeps within the UtxoSweeper

d75fac2

lnrpc/walletrpc: expose pending input sweeps within UtxoSweeper over RPC

d01f88e

wpaulino force-pushed the pendingsweeps-rpc branch from fcb0467 to 26230cd Compare June 5, 2019 19:11

wpaulino force-pushed the pendingsweeps-rpc branch 3 times, most recently from ebecc4f to ab1491f Compare June 6, 2019 00:57

cfromknecht approved these changes Jun 6, 2019

View reviewed changes

cmd/lncli/types.go Outdated Show resolved Hide resolved

wpaulino force-pushed the pendingsweeps-rpc branch from ab1491f to 71f3ee1 Compare June 6, 2019 09:56

cmd/lncli: expose pending input sweeps within UtxoSweeper over lncli

1d8b70e

wpaulino force-pushed the pendingsweeps-rpc branch from 71f3ee1 to 1d8b70e Compare June 6, 2019 10:23

Roasbeef merged commit aa5156a into lightningnetwork:master Jun 6, 2019

wpaulino deleted the pendingsweeps-rpc branch June 6, 2019 18:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sweep+rpc+cmd/lncli: expose pending input sweeps over RPC + CLI #3089

sweep+rpc+cmd/lncli: expose pending input sweeps over RPC + CLI #3089

wpaulino commented May 17, 2019

wpaulino commented May 17, 2019

Roasbeef left a comment

Roasbeef May 25, 2019

joostjager May 28, 2019

wpaulino May 28, 2019

Roasbeef left a comment

cfromknecht left a comment

cfromknecht commented Jun 1, 2019

wpaulino commented Jun 5, 2019

joostjager left a comment

wpaulino commented Jun 5, 2019

cfromknecht left a comment

sweep+rpc+cmd/lncli: expose pending input sweeps over RPC + CLI #3089

sweep+rpc+cmd/lncli: expose pending input sweeps over RPC + CLI #3089

Conversation

wpaulino commented May 17, 2019

wpaulino commented May 17, 2019

Roasbeef left a comment

Choose a reason for hiding this comment

Roasbeef May 25, 2019

Choose a reason for hiding this comment

joostjager May 28, 2019

Choose a reason for hiding this comment

wpaulino May 28, 2019

Choose a reason for hiding this comment

Roasbeef left a comment

Choose a reason for hiding this comment

cfromknecht left a comment

Choose a reason for hiding this comment

cfromknecht commented Jun 1, 2019

wpaulino commented Jun 5, 2019

joostjager left a comment

Choose a reason for hiding this comment

wpaulino commented Jun 5, 2019

cfromknecht left a comment

Choose a reason for hiding this comment